Add CI checks for formatting + clean up CI #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix unused variables across multiple Python files - Fix syntax error in zencoder/test_starcoder_bigcode.py - Exclude Jupyter notebooks from linting checks in format.sh 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
strickvl
changed the title
- Created new GitHub Actions workflow 'code-formatting.yml' that runs the formatting script - Workflow checks if code meets formatting standards and fails if any changes are needed - Updated pull_request.yml to include the new formatting check - Ensures PRs cannot be merged until code passes formatting checks
There was a problem hiding this comment.
Pull Request Overview
This PR enhances CI workflows by adding automated formatting checks, removes outdated CI files, and applies consistent code formatting fixes across the codebase.
- Updated
scripts/format.shto exclude Jupyter notebooks from linting and introduced a GitHub Actions workflow to enforce formatting - Removed deprecated CI workflows and updated
pull_request.ymlto include the new formatting check - Standardized multiline return type annotations and cleaned up unused variables/imports in various pipeline and utility modules
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/format.sh | Exclude *.ipynb in ruff checks |
| retail-forecast/pipelines/training_pipeline.py | Normalize multiline return type annotation |
| magic-photobooth/modal_run_using_azure_data.py | Normalize return type annotation, discard unused load_data |
| magic-photobooth/modal_run.py | Normalize return type annotation |
| magic-photobooth/k8s_run.py | Normalize return type annotation |
| magic-photobooth/frontend.py | Removed assignment from st.selectbox |
| llm-complete-guide/utils/llm_utils.py | Removed unused source-variable logic and query construction |
| llm-complete-guide/steps/populate_index.py | Removed unused bucket_ranges list |
| llm-complete-guide/steps/hf_dataset_loader.py | Normalize multiline return type annotation |
| llm-complete-guide/steps/eval_retrieval.py | Normalize multiline return type annotations |
| huggingface-sagemaker/steps/promotion/promote_get_metrics.py | Normalize multiline return type annotation |
| huggingface-sagemaker/steps/deploying/huggingface_deployment.py | Adjust multiline assert formatting |
| gamesense/steps/log_metadata.py | Remove unused import and replace unused var with discard _ |
| databricks-production-qa-demo/steps/deployment/deployment_deploy.py | Normalize multiline return type annotation |
| .github/workflows/staging_run_complete_llm.yml | Removed outdated workflow |
| .github/workflows/pull_request.yml | Renamed workflow and added code-formatting-check |
| .github/workflows/production_run_complete_llm.yml | Removed outdated workflow |
| .github/workflows/gpt4_summarizer.yml | Removed outdated workflow |
| .github/workflows/code-formatting.yml | Added new formatting CI workflow |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…zenml-projects into ci/force-formatting-gh-actions
|
@AlexejPenner I removed the CI yaml files as we weren't using them and it was just adding noise. Hope that's ok! |
htahir1
approved these changes
May 17, 2025
safoinme
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Formatting and CI Improvements
This PR makes several improvements to code quality and CI/CD workflows:
🧹 Code Formatting Fixes
Fixed various code quality issues across the repository:
Removed unused variables (F841) in multiple projects:
Fixed syntax error in zencoder/test_starcoder_bigcode.py
🔧 CI/CD Improvements
Enhanced CI/CD pipeline for better code quality:
📝 Tool Configuration Updates
This PR ensures that future contributions maintain consistent code formatting standards, making the codebase more maintainable and reducing noise in code reviews.
Commit History