Skip to content

✅ update tests to use getByRole or getByText #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2023
Merged

✅ update tests to use getByRole or getByText #397

merged 2 commits into from
Aug 28, 2023

Conversation

thibaudbrault
Copy link
Contributor

This pr removes nearly every .locator and replaces them with .getByRole and .getByText to be closer to the user experience

@thibaudbrault thibaudbrault linked an issue Aug 7, 2023 that may be closed by this pull request
Use only accessible locators in e2e tests #388
Closed
@hgwood hgwood marked this pull request as ready for review August 28, 2023 12:41
hgwood
hgwood approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@hgwood hgwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 You can merge this once the lint job is green.

@hgwood hgwood mentioned this pull request Aug 28, 2023
Merged
@hgwood hgwood merged commit b586fcc into main Aug 28, 2023
@hgwood hgwood deleted the refactoTests branch August 28, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hgwood hgwood hgwood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use only accessible locators in e2e tests

2 participants

@thibaudbrault @hgwood