Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow logging to past days #83

Open
skoppelmanCC opened this issue Apr 26, 2017 · 0 comments · Fixed by jferg-newcontext/hcl#2
Open

allow logging to past days #83

skoppelmanCC opened this issue Apr 26, 2017 · 0 comments · Fixed by jferg-newcontext/hcl#2

Comments

@skoppelmanCC
Copy link

Some possibilities:

hcl log yesterday @documentation +2 Ran spellcheck
hcl log 3 days ago @wireframes +3.5
hcl log last friday @admin +1 filed timesheets
teddywing added a commit to teddywing/hcl that referenced this issue Jan 28, 2018
Adds an optional date argument to the `log` command that can be
specified just before the task alias.

Some examples from @skoppelmanCC:

hcl log yesterday @documentation +2 Ran spellcheck
hcl log 3 days ago @wireframes +3.5
hcl log last friday @admin +1 filed timesheets

Fixes zenhob#83.
teddywing added a commit to teddywing/hcl that referenced this issue Jan 28, 2018
Adds an optional date argument to the `log` command that can be
specified just before the task alias.

Some examples from @skoppelmanCC:

hcl log yesterday @documentation +2 Ran spellcheck
hcl log 3 days ago @wireframes +3.5
hcl log last friday @admin +1 filed timesheets

command_test.rb(#test_start):
Update expected method call arguments with `spent_at`. Now that we're
passing in `spent_at`, the expected arguments should include it.

utility_test.rb: Add tests for `#get_date`

Fixes zenhob#83.
teddywing added a commit to teddywing/hcl that referenced this issue Jan 28, 2018
Adds an optional date argument to the `log` command that can be
specified just before the task alias.

Some examples from @skoppelmanCC:

hcl log yesterday @documentation +2 Ran spellcheck
hcl log 3 days ago @wireframes +3.5
hcl log last friday @admin +1 filed timesheets

command_test.rb(#test_start):
Update expected method call arguments with `spent_at`. Now that we're
passing in `spent_at`, the expected arguments should include it.

utility_test.rb: Add tests for `#get_date`

Fixes zenhob#83.
teddywing added a commit to teddywing/hcl that referenced this issue Jan 31, 2018
Adds an optional date argument to the `log` command that can be
specified just before the task alias.

Some examples from @skoppelmanCC:

    hcl log yesterday @documentation +2 Ran spellcheck
    hcl log 3 days ago @wireframes +3.5
    hcl log last friday @admin +1 filed timesheets

Commands#log:
Copy over the contents of `Commands#start` and replace `task.start` with
`task.add`. This allows us to log the time without actually starting a
timer (and thus having to subsequently stop that timer).

command_test.rb(#test_start):
Update expected method call arguments with `spent_at`. Now that we're
passing in `spent_at`, the expected arguments should include it.

command_test.rb(#test_log_failure):
Delete this test because I've rewritten the `Commands#log` method to no
longer use timers.

utility_test.rb: Add tests for `#get_date`

Fixes zenhob#83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants