This repository was archived by the owner on May 24, 2018. It is now read-only.
[2.1][2175] Added doc for dateSelect/monthSelect #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a link to Wikipedia explaining the term DRY for people who don't know what it means.
Added a link to Wikipedia explaining the term DRY for people who don't know what it means.
Added missing brackets.
Correct form view example
Fix paginator classname
- Both were missing an end paren (')')
Removed Zend_Rest as they have passwd away
…uickstart-examples Fixed examples rendering csrf and button
- Element specifications within factory example were done incorrectly
…uick-start-factory [ZF2-526] Fix example of form factory
Update docs/languages/en/modules/zend.paginator.usage.rst
| @@ -36,7 +36,7 @@ The following methods are in addition to the inherited :ref:`methods of Zend\\Fo | |||
| .. function:: setOptions(array $options) | |||
| :noindex: | |||
|
|
|||
| Set options for an element of type Collection. Accepted options, in addition to the inherited options of Zend\\Form\\Element <zend.form.element.methods.set-options>` , are: ``"target_element"``, ``"count"``, ``"allow_add"``, ``"should_create_template"`` and ``"template_placeholder"`` , which call ``setTargetElement``, ``setCount``, ``setAllowAdd``, ``setShouldCreateTemplate`` and ``setTemplatePlaceholder`` , respectively. | |||
| Set options for an element of type Collection. Accepted options, in addition to the inherited options of Zend\\Form\\Element <zend.form.element.methods.set-options>` , are: ``"target_element"``, ``"count"``, ``"allow_add"``, ``"allow_remove"``, ``"should_create_template"`` and ``"template_placeholder"`` , which call ``setTargetElement``, ``setCount``, ``setAllowAdd``, ``setAllowRemove``, ``setShouldCreateTemplate`` and ``setTemplatePlaceholder`` , respectively. | |||
There was a problem hiding this comment.
May I suggest to split up thise line, around 'which call'? Otherwise it will be one sentence with two fairly large enumerations.
…uction Rewrote Zend.mail.introduction for ZF2
…ion into form/date-select
|
Seems the history of this PR is messed |
|
@bakura10 It seems somehow this PR includes a bit too many commits. Could you please look at that, or seek assistance on IRC or the Mailing Lists? In this current state I'm hesitant to merging this. |
|
I'm closing too. I'll review Form docs today and tomorrow, and this one has changed too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the doc for this related PR : zendframework/zendframework#2175
(as well as an addition to a new feature of Collection that I didn't documented before).