PSR-7 file validation implemented

[icetee]

This commit allows validation files with $request->getUploadedFiles().

But I got stuck in testing. I want to be able to use a $upload->getStream()->getMetadata('uri') and return example /tmp/abcd.

$stream = $this->prophesize(StreamInterface::class);
$upload = $this->prophesize(UploadedFileInterface::class);

$stream->getMetadata('uri')->willReturn($testFile);

$upload->getClientFilename()->willReturn('csgo.mo');
$upload->getClientMediaType()->willReturn('mo');
$upload->getError()->willReturn(0);
$upload->getStream()->willReturn($stream->reveal());
$upload->reveal();

$upload->getStream()->getMetadata('uri'); // Call to undefined method Prophecy\Prophecy\MethodProphecy::getMetadata()   

[weierophinney]

@icetee we already have support for validating PSR-7 uploaded files as of version 2.11.0; the support is even documented.

[froschdesign]

@weierophinney
But this support will not work for (file) validators like Size, MimeType and so on.

[froschdesign]

Related to zendframework/zend-form#227

[weierophinney]

I've left a number of comments at this point with directions on changes necessary for us to merge.

With regards to the testing: it sounds like perhaps the PSR-7 library is not installed locally. Run composer list | grep http-message and check to ensure it's present. That method is definitely part of the spec and the interfaces, so that's where I'd start.

[weierophinney]

Please do not use extract(). Assign the return value to a variable, and pull elements out it.

[weierophinney]

Same comment here.

[weierophinney]

etc.

Please review all code for elements where you have done this and update.

[weierophinney]

Use the compact form of the license, please:

/**
 * @see       https://github.com/zendframework/zend-validator for the canonical source repository
 * @copyright Copyright (c) 2019 Zend Technologies USA Inc. (https://www.zend.com)
 * @license   https://github.com/zendframework/zend-validator/blob/master/LICENSE.md New BSD License

(note that since this is a new file, the copyright date is only this year.)
*/

[weierophinney]

Please extract the different cases into separate private methods; doing so will make it easier to read the method and understand where the individual pieces come from. It will also allow you to return early, removing the elseif/else conditions:

if (is_string($value && is_array($file)) {
    return $this->getLegacyFileInfo($file, $hasType);
}

if (is_array($value)) {
    return $this->getSapiFileInfo($file, $hasType);
}

if ($value instanceof UploadedFileInterface) {
    return $this->getPsr7FileInfo($value, $hasType);
}

return $this->getFileBasedFileInfo($file, $hasType);

These methods can then be re-used in the getFileInfoExists() method, allowing you to act based on the return values.

[froschdesign]

This method call is a problem, because setValue() does not exists in the current trait and that results in a false dependency.

[icetee]

I pushed the changes.

@weierophinney I have http-message package composer show -i | grep http-message.

[weierophinney]

The strategy of testing the FileInformationTrait is great, as then the tests for the individual validators do not need to change, and we can still be assured that they will operate regardless of the file upload SAPI in place. Nice work!

It looks like the various test failures reported by Travis are not your fault; they appear to be timing issues. I'll try rebasing your PR against current develop to see if recent changes make those go away before I merge.

[icetee]

Maybe related build failed - #257

[weierophinney]

@icetee Yes, and I just pushed a fix for that to develop. 😄