This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Fix hostname subdomain underscore #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacinsky
force-pushed
the
fix/hostname-subdomain-underscore
branch
2 times, most recently
from
9bafe38 to
9193c9c
Compare
weierophinney
force-pushed
the
fix/hostname-subdomain-underscore
branch
from
9193c9c to
f4c26cf
Compare
Renames `testUnderscore` to `testValidatorHandlesUnderscoresInDomainsCorrectly()`, and has it use a data provider with individual inputs and assertions.
weierophinney
added a commit
that referenced
this pull request
Dec 13, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 13, 2018
|
Thanks, @bacinsky |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing underscore in hostname subdomains.