This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Fix testCount for PHP 7.2 #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7.2 raise a deprecated message Parameter must be an array or an object that implements Countable I think this should not be hidden (count could take care of this), so this change declare the message as expected. A new test is added for object which are really countable
| public function testCountable() | ||
| { | ||
| $ar = new ArrayObject(new TestAsset\ArrayObjectObjectCount()); | ||
| $this->assertEquals(42, $ar->count()); |
There was a problem hiding this comment.
this is a copy/paste from previous test, I don't want to do refactoring in a PR only design to fix a minor compatibility issue.
Feel free to open a separate PR if you really think this worth the work ;)
There was a problem hiding this comment.
You add these new lines, so please use the correct method. Thanks!
There was a problem hiding this comment.
ok.
No time for Bikeshedding.
froschdesign
suggested changes
Oct 24, 2017
| public function testCountable() | ||
| { | ||
| $ar = new ArrayObject(new TestAsset\ArrayObjectObjectCount()); | ||
| $this->assertEquals(42, $ar->count()); |
There was a problem hiding this comment.
You add these new lines, so please use the correct method. Thanks!
Closed
|
@remicollet |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.2 raise a deprecated message
Parameter must be an array or an object that implements Countable
I think this should not be hidden (count could take care of this),
so this change declare the message as expected.
A new test is added for object which are really countable
Detected by Fedora QA with 7.2.0RC4
https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-stdlib?collection=f28