This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Update Zend\Stdlib\Hydrator\HydratorInterface to extend Zend\Hydrator\HydratorInterface #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bstitutable for Zend\Hydrator\HydratorInterface
|
Looks good — and excellent tests! Will merge in the morning and tag a new release. Thanks, Adam! |
|
|
||
| /** | ||
| * @deprecated Use Zend\Hydrator\HydratorInterface from zendframework/zend-hydrator instead. | ||
| */ | ||
| interface HydratorInterface extends HydrationInterface, ExtractionInterface | ||
| interface HydratorInterface extends BaseHydratorInterface |
There was a problem hiding this comment.
I think BaseHydratorInterface should be append to the extend list and not replace previous interfaces.
This IMO the way of maintain compatibility is appending new interfaces and maintain the old ones in the list too.
There was a problem hiding this comment.
Thanks for catching that! In the current state any methods typehinting on the deprecated Zend\Stdlib\Hydrator\HydrationInterface or Zend\Stdlib\Extractor\ExtractionInterface will no longer accept objects implementing Zend\Stdlib\Hydrator\HydratorInterface
…methods typehinted on deprecated HydrationInterface and ExtractorInterface
… typehinted on deprecated HydrationInterface and ExtractorInterface
weierophinney
added a commit
that referenced
this pull request
Sep 23, 2015
Update Zend\Stdlib\Hydrator\HydratorInterface to extend Zend\Hydrator\HydratorInterface
weierophinney
added a commit
that referenced
this pull request
Sep 23, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25