Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

replace strstr with strpos #250

Merged
merged 2 commits into from
Nov 24, 2017
Merged

replace strstr with strpos #250

merged 2 commits into from
Nov 24, 2017

Conversation

samsonasik
Copy link
Contributor

based on php manual at http://php.net/manual/en/function.strstr.php

 If you only want to determine if a particular needle occurs within haystack, use the faster and less memory intensive function strpos() instead.

@samsonasik
Copy link
Contributor Author

it seems it was on purpose https://3v4l.org/5MX6d , closing

@samsonasik samsonasik closed this Jul 18, 2017
@samsonasik
Copy link
Contributor Author

samsonasik commented Jul 19, 2017 •
edited
Loading

re-open, use false !== for the replaced to strpos usage https://3v4l.org/gkHYg

@samsonasik samsonasik reopened this Jul 19, 2017
@froschdesign froschdesign added this to the 3.1.1 milestone Jul 19, 2017
@Xerkus Xerkus merged commit fcdc6c5 into zendframework:master Nov 24, 2017
Xerkus added a commit that referenced this pull request Nov 24, 2017
@Xerkus
Merge branch 'hotfix/250'
831db33 
Close #250
Xerkus added a commit that referenced this pull request Nov 24, 2017
@Xerkus
Merge branch 'hotfix/250' into develop
8e17a05 
Forward port #250
@samsonasik samsonasik deleted the strstr-strpos branch November 24, 2017 06:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@froschdesign froschdesign froschdesign approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @froschdesign @Xerkus