This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Clarify AcceptableViewModelSelector parsing and browser behavior #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| protected $acceptCriteria = [ | ||
| // Make sure ViewModel is the first as a fallback |
There was a problem hiding this comment.
Every browser will send text/html at a higher priority than */* so as long as a ViewModel with a HTML mimetype is in $acceptCriteria it will work.
There was a problem hiding this comment.
I've added this line to make sure that ViewModel will be the intended fallback for all unmatched parts.
There was a problem hiding this comment.
Fair point. I would then just change the wording slightly as it assumes that I want HTML as the fallback. Maybe "The first model in the list will be used as the default in case of no exact match", or similar ?
|
Any news on this PR? |
weierophinney
added a commit
that referenced
this pull request
Aug 29, 2016
Clarify AcceptableViewModelSelector parsing and browser behavior
weierophinney
added a commit
that referenced
this pull request
Aug 29, 2016
|
Thank you, @MatthiasKuehneEllerhold. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #194 for discussion.