This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Update zend-mvc v2 to use zend-servicemanager-di #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zend-servicemanager-di contains tests and code to ensure it works against both v2 and v3 versions of zend-servicemanager, unlike the code currently in zend-mvc. Updating to use it is backwards compatible, assuming the following: - zend-servicemanager-di is tested against both v2 and v3 of zend-servicemanager, demonstrating that the various classes it contains that overlap with zend-servicemanager v2 pose no conflicts. - each of DiAbstractServiceFactoryFactory, DiFactory, DiServiceInitializerFactory, and DiStrictAbstractServiceFactory from zend-mvc v2 return artifacts from the `Zend\ServiceManager\Di` namespace, allowing them to simply extend the relevant factories that exist in zend-servicemanager-di. - DiStrictAbstractServiceFactoryFactory can be left intact, ensuring it returns the `Zend\Mvc\Service\DiStrictAbstractServiceFactory` instance, and thus preserving the inheritance tree. All of the DI-related factories in zend-mvc are now marked deprecated as well, with annotations detailing how to upgrade code to work with zend-servicemanager-di to make it forwards-compatible.
weierophinney
added a commit
that referenced
this pull request
Jun 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend-servicemanager-di contains tests and code to ensure it works against both v2 and v3 versions of zend-servicemanager, unlike the code currently in zend-mvc. Updating to use it is backwards compatible, assuming the following:
Zend\ServiceManager\Dinamespace, allowing them to simply extend the relevant factories that exist in zend-servicemanager-di.Zend\Mvc\Service\DiStrictAbstractServiceFactoryinstance, and thus preserving the inheritance tree.All of the DI-related factories in zend-mvc are now marked deprecated as well, with annotations detailing how to upgrade code to work with zend-servicemanager-di to make it forwards-compatible.
This pull request supercedes #149 (the tests of which were incorporated directly in zend-servicemanager-di).