This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Fixes BC-Issue due to removed error-handler #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a BC-Issue caused by removing the Zend\StdLib\ErrorHandler and replacing it with a class that does nothing. Out of the Box that caused some functions to throw errors instead of the expected Exceptions. The replacement-class for the Zend\StdLib\ErrorHandler now sets (and removes) an empty errorHandler. Thanks to @sgehrig for mentioning and reaching out!
|
@heiglandreas can you add a test case for this scenario? Something that triggers a notice would be OK, and just having the notice suppressed in the test would be sufficient, IMO |
|
In the bootstrap.php there is an ErrorHandler injected into the ErrorHandler. Due to that the issue didn't surface in the first place. I'll remove that line to make sure everything works out of the box. That should then be sufficient. Or don't you think? |
|
@heiglandreas I mean a test specific for the ErrorHandler class |
|
Will do so ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a BC-Issue caused by removing the Zend\StdLib\ErrorHandler and replacing it with a class that does nothing. Out of the Box that caused some functions to throw errors instead of the expected Exceptions.
The replacement-class for the Zend\StdLib\ErrorHandler now sets (and removes) an empty errorHandler.
Thanks to @sgehrig for mentioning and reaching out!
This fixes #46