This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Ensures return type safety of composed factories #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch decorates the passed factory arguments to the `RequestHandlerRunner` constructor in closures that provide return type hints; this ensures that if a value of a different type is returned by either factory, a PHP `TypeError` will be raised indicating that fact.
weierophinney
added a commit
that referenced
this pull request
Feb 21, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 21, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 21, 2018
Forward-port #2 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch decorates the passed factory arguments to the
RequestHandlerRunnerconstructor in closures that provide return type hints; this ensures that if a value of a different type is returned by either factory, a PHPTypeErrorwill be raised indicating that fact.