Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Method setCookies on Client accepts name=>value pairs or SetCookie instances #188

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Method setCookies on Client accepts name=>value pairs or SetCookie instances #188

merged 2 commits into from
Nov 29, 2019

Conversation

michalbundyra
Copy link
Member

Per documentation it should be possible to pass array of SetCookie to Client::setCookies.

Fixes #114

See: https://docs.zendframework.com/zend-http/client/cookies/#usage

$client->setUri($uri);
$client->setCookies($cookies->getMatchingCookies($uri));

and method getMatchingCookies return array of SetCookie.

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

…stances

Per documentation it should be possible to pass array of SetCookie
to Client::setCookies.

Fixes #114
@michalbundyra michalbundyra added this to the 2.10.1 milestone Sep 28, 2019
It can be only array as defined in method signature
michalbundyra added a commit that referenced this pull request Nov 29, 2019
Method setCookies on Client accepts name=>value pairs or SetCookie instances
michalbundyra added a commit that referenced this pull request Nov 29, 2019
michalbundyra added a commit that referenced this pull request Nov 29, 2019
@michalbundyra michalbundyra merged commit 052db7b into zendframework:master Nov 29, 2019
@michalbundyra michalbundyra deleted the hotfix/client-set-cookies branch November 29, 2019 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some type of set-cookie issue
2 participants