Fix for timeout config parameter validation

[klimser]

Validation conditions for integer or numeric timeout was mutually exclusive, fixed.

[michalbundyra]

@klimser We need add unit tests to cover these changes.

[klimser]

@webimpress There are already existed tests that were failed and now passed:

• test/Client/CurlTest/testPassValidTimeout
• test/Client/SocketTest/testPassValidTimeout

[michalbundyra]

@klimser

There are already existed tests that were failed ...

3 days ago builds on master and develop pass and nothing has been changed since then. How do you mean that these test were failing? Where?

[klimser]

@klimser

There are already existed tests that were failed ...

3 days ago builds on master and develop pass and nothing has been changed since then. How do you mean that these test were failing? Where?

I've updated my project to current release -> project was destroyed -> I found the reason, place in code ->I found that changes were made with tests -> I ran tests -> I got exception -> I fixed a bug -> Tests passed -> I created a pull request.

[klimser]

@webimpress

@klimser

There are already existed tests that were failed ...

3 days ago builds on master and develop pass and nothing has been changed since then. How do you mean that these test were failing? Where?

These tests are run only when TESTS_ZEND_HTTP_CLIENT_BASEURI set to true and skipped otherwise, maybe it's the reason?

[samsonasik]

actually, the ! is_int($connectTimeout) is not needed as the ! is_numeric() already cover it, and later will always be casted to (int) $connectTimeout in next line.

[klimser]

actually, the ! is_int($connectTimeout) is not needed as the ! is_numeric() already cover it, and later will always be casted to (int) $connectTimeout in next line.

Agree. Fixed.

[michalbundyra]

@klimser I had another look on it and I can confirm it was a bug, and your fix is correct. We haven't seen it in tests, because as you noticed these test were skipped. It would be nice to enable them on Travis.

Anyway - LGTM 👍 Thanks!

[weierophinney]

Thanks, @klimser.