Bugfix for 2.9.0 BC Break when using traditional SAPI #79
Conversation
| /** | ||
| * @see https://github.com/zendframework/zend-filter/issues/77 | ||
| */ | ||
| public function testBackwordCompatibilityBreakFromRelease280ToRelease290() |
There was a problem hiding this comment.
This test runs successfully on release-2.8.0 but fails on release-2.9.0
There was a problem hiding this comment.
Let's give it a name that details the behavior being tested, not the symptom. 😄
Something like testCachesResultsOfFilteringSAPIUploads().
(I can make that change on merge.)
Slamdunk
changed the title
Slamdunk
changed the title
|
@Slamdunk : tested and it's ok 👍 |
There was a problem hiding this comment.
The tests are great (albeit with naming issues); I'll get this out ASAP.
Thanks, @Slamdunk !
| /** | ||
| * @see https://github.com/zendframework/zend-filter/issues/77 | ||
| */ | ||
| public function testBackwordCompatibilityBreakFromRelease280ToRelease290() |
There was a problem hiding this comment.
Let's give it a name that details the behavior being tested, not the symptom. 😄
Something like testCachesResultsOfFilteringSAPIUploads().
(I can make that change on merge.)
| * @see https://github.com/zendframework/zend-filter/issues/76 | ||
| * @return void | ||
| */ | ||
| public function testTargetSameAsSource() |
There was a problem hiding this comment.
Similar comment here; the test name isn't telling me what the behavior being tested is. Let's try something along the lines of testFilterReturnsFileDataVerbatimUnderSAPIWhenNameAndTmpNameDiffer().
Forward port #79 Conflicts: CHANGELOG.md
References: #76, #77
Provide a narrative description of what you are trying to accomplish:
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.