Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Replace container-interop with PSR-11 container interface #52

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Replace container-interop with PSR-11 container interface #52

wants to merge 2 commits into from

Conversation

michaelmoussa
Copy link

This PR replaces use of the container-interop package with the PSR-11 container interface. This is obviously a BC break and would need to be released in EventManager 4.0 along with a migration guide.

This PR is being submitted in conjunction with a similar PR on the zend-framework/zend-servicemanager repository. Before merging and releasing the zend-servicemanager PR, this one should be merged and released with a new major version, and the zend-servicemanager should have its Composer dependencies updated to include version 4.0 of zend-eventmanager.

composer.json Outdated
"zendframework/zend-coding-standard": "~1.0.0"
},
"suggest": {
"container-interop/container-interop": "^1.1.0, to use the lazy listeners feature",
"psr/container": "^1.0.0, to use the lazy listeners feature",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In requireand suggest?!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@froschdesign good catch - should have been require-dev (not require) and suggest. Fixed.Thanks!

@michaelmoussa
Copy link
Author

@weierophinney rebased this one w/changes from latest develop. The migration guide in this repo is organized differently from what I already did in ServiceManager... where would you like this part documented?

@michaelmoussa
Copy link
Author

Added a fix to the existing "Replace container-interop with PSR-11" commit for the failing tests.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-eventmanager; a new issue has been opened at laminas/laminas-eventmanager#5.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-eventmanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-eventmanager to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-eventmanager.
  • In your clone of laminas/laminas-eventmanager, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants