-
Notifications
You must be signed in to change notification settings - Fork 62
Replace container-interop with PSR-11 container interface #52
base: develop
Are you sure you want to change the base?
Conversation
composer.json
Outdated
"zendframework/zend-coding-standard": "~1.0.0" | ||
}, | ||
"suggest": { | ||
"container-interop/container-interop": "^1.1.0, to use the lazy listeners feature", | ||
"psr/container": "^1.0.0, to use the lazy listeners feature", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In require
and suggest
?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@froschdesign good catch - should have been require-dev
(not require
) and suggest
. Fixed.Thanks!
@weierophinney rebased this one w/changes from latest |
Added a fix to the existing "Replace |
This repository has been closed and moved to laminas/laminas-eventmanager; a new issue has been opened at laminas/laminas-eventmanager#5. |
This repository has been moved to laminas/laminas-eventmanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This PR replaces use of the
container-interop
package with the PSR-11 container interface. This is obviously a BC break and would need to be released in EventManager 4.0 along with a migration guide.This PR is being submitted in conjunction with a similar PR on the
zend-framework/zend-servicemanager
repository. Before merging and releasing thezend-servicemanager
PR, this one should be merged and released with a new major version, and thezend-servicemanager
should have its Composer dependencies updated to include version 4.0 ofzend-eventmanager
.