This repository was archived by the owner on Jan 29, 2020. It is now read-only.
fix #255 - Don't evaluate '0' as empty #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psr-7 StreamInterface::read() returns only string, so don't need check it is empty-like value
kelunik
reviewed
Jul 13, 2017
| $this->stream->getContents(); | ||
| $this->assertStreamContents($this->stream->getContents()); | ||
|
|
||
| $stream = new PhpInputStream('data://,0'); |
There was a problem hiding this comment.
I intended just represent string(1) "0" for PHP's stream. ( http://php.net/wrappers.data )
There was a problem hiding this comment.
a very trivial data:// URL, without mime, charset or base64. (see RFC 2397, 3. syntax)
In this case, with just 0 as contents.
weierophinney
added a commit
that referenced
this pull request
Aug 17, 2017
fix #255 - Don't evaluate '0' as empty
weierophinney
added a commit
that referenced
this pull request
Aug 17, 2017
|
Thanks, @sasezaki |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psr-7 StreamInterface::read() returns only string, so don't need check it is empty-like value
fix #255