This repository was archived by the owner on Jan 29, 2020. It is now read-only.
PHP session cookies are no longer broken #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using native PHP sessions with cookies, PHP will set a cookie whenever a session is created or regenerated. Adding an additional `Set-Cookie` header in the same request will cause the PHP `Set-Cookie` header to be lost. Ideally native PHP sessions with cookies should be avoided when using PSR-7 compatible classes, but that is not always possible - this PR makes sure PHP's session cookies are not lost.
weierophinney
added a commit
that referenced
this pull request
Aug 17, 2017
PHP session cookies are no longer broken
weierophinney
added a commit
that referenced
this pull request
Aug 17, 2017
weierophinney
added a commit
that referenced
this pull request
Aug 17, 2017
|
Thanks, @vakata |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using native PHP sessions with cookies, PHP will set a cookie whenever a session is created or regenerated. Adding an additional
Set-Cookieheader in the same request will cause the PHPSet-Cookieheader to be lost. Ideally native PHP sessions with cookies should be avoided when using PSR-7 compatible classes, but that is not always possible - this PR makes sure PHP's session cookies are not lost.