Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Page for background-collection #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Blaimi
Copy link

@Blaimi Blaimi commented May 3, 2016

this PR sets up a page, where you can view former collected toolbar entries by accessing the route /zdt-background-reque.

Known Bugs:

  • It’s ugly
  • If you scroll to the page’s bottom, it’s horrible to read the bar’s content
  • it uses a very high amount of memory

Missing:

  • Tests
  • Some cookie-stuff to assign and filter the requests (that’s, what the :uuid in the route is for)
  • A way to cleanup the cache
  • Review

@weierophinney
Copy link
Member

@Blaimi Are you still working on this? If so, could you rebase, and also please provide a screenshot detailing what is displayed? I'm not entirely sure what this will do in its current state. 😄

Thanks in advance!

@Blaimi
Copy link
Author

Blaimi commented Sep 9, 2016

We are using this version in our development-process but for zend 2.4.

It’s working, but not very intuitive, very slow and it crashes, if you have more than ~25 lines/toolbars. Since the cache is not cleaning up itself and the page displays everytime everything available 25 lines are reached very fast.

To answer your question: yes, we are still working with it. We are planning to migrate/update to Zend3 but not in the next few weeks. Maybe in Q1/17 along with the migration to Debian 9 and php7. I don’t think that we have much spare time to invest in this project since we are unable to use the current version of zdt (depends on zend ^3.0) in our own development-process.

zdt-background-requests

@weierophinney
Copy link
Member

I think this is definitely an interesting feature. However, we need unit tests for the new functionality.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-developer-tools; a new issue has been opened at laminas/laminas-developer-tools#5.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-developer-tools. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-developer-tools to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-developer-tools.
  • In your clone of laminas/laminas-developer-tools, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants