This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Create AbstractExpressiveContainerConfigTest with required test traits composed #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s composed This patch builds on [a comment on #2](#2 (comment)). First, it renames `ContainerTest` to `AbstractContainerTest`, in order to follow our naming guidelines for abstract classes. Second, it introduces `ExpressiveTestTrait`, which composes the various traits that are _required_ by implementations in order to be compatible with Expressive configuration. Third, it modifies `AllTestTrait` to use `ExpressiveTestTrait` as well as `SharedTestTrait`. Fourth, it introduces `AbstractExpressiveContainerConfigTest`, which extends `AbstractContainerTest` and composes `ExpressiveTestTrait`. Fifth, it removes the `BaseContainerTest` as redundant to the new `AbstractExpressiveContainerConfigTest`, and updates all test classes to extend it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on a comment on #2.
First, it renames
ContainerTesttoAbstractContainerTest, in order to follow our naming guidelines for abstract classes.Second, it introduces
ExpressiveTestTrait, which composes the various traits that are required by implementations in order to be compatible with Expressive configuration.Third, it modifies
AllTestTraitto useExpressiveTestTraitas well asSharedTestTrait.Fourth, it introduces
AbstractExpressiveContainerConfigTest, which extendsAbstractContainerTestand composesExpressiveTestTrait.Fifth, it removes the
BaseContainerTestas redundant to the newAbstractExpressiveContainerConfigTest, and updates all test classes to extend it.