This repository was archived by the owner on Jan 1, 2020. It is now read-only.
Update Dockerfile to fix DocumentRoot config file #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamlundrigan
suggested changes
Oct 4, 2016
| @@ -4,7 +4,7 @@ RUN apt-get update \ | |||
| && apt-get install -y git zlib1g-dev \ | |||
| && docker-php-ext-install zip \ | |||
| && a2enmod rewrite \ | |||
| && sed -i 's!/var/www/html!/var/www/public!g' /etc/apache2/apache2.conf \ | |||
| && sed -i 's!/var/www/html!/var/www/public!g' /etc/apache2/sites-enabled/000-default.conf \ | |||
There was a problem hiding this comment.
Is it sufficient to just update the default vhost, or should we continue to also update apache2.conf?
There was a problem hiding this comment.
by default apache2.conf includes every sites-enabled/*.conf file.
So, you don't require edit your apache2.conf file
|
Push, push, push. This change came just in time for me (after trying to solve it myself). |
|
Just wasted 30 minutes tracking this same problem down :( Merge please! |
|
Duplicate #361. For more information please check my comments: |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.