This repository was archived by the owner on Dec 7, 2019. It is now read-only.
Added action creation#69
Closed
fmarcoux96 wants to merge 2 commits intozendframework:masterfrom
fmarcoux96:master
Closed
Added action creation#69fmarcoux96 wants to merge 2 commits intozendframework:masterfrom fmarcoux96:master
fmarcoux96 wants to merge 2 commits intozendframework:masterfrom
fmarcoux96:master
Conversation
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2013
- indentation - trailing whitespace
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2013
Action creation was completely broken. Variables were referenced before being declared, messages were written to the console before it was in scope, and the route was using a "controller" segment, which will not work, as it overwrites the default for the controller to dispatch. Paths for view scripts were being generated incorrectly, and code reflection/generation were being done in a way that didn't work. This commit fixes all of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the action creation and also updated README.md to reflect changes.