feat(accordions): new light/dark mode colors #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
reviewed
Jul 10, 2024
Contributor
Author
jzempel
reviewed
Jul 12, 2024
Member
jzempel
left a comment
jzempel
left a comment
There was a problem hiding this comment.
Final update from me ... Can we update the description for ITimelineItemProps['surfaceColor'] in types/index.ts from
"Provides surface color for an icon placed on a non-white background"
to
"Provides surface color for an icon placed on a non-default background"
jzempel
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accordion,Stepper, andTimelineDetail
Accordion,Stepper, andTimelineChecklist
npm start)⬅️ renders as expected with reversed (RTL) direction🤘 renders as expected with Bedrock CSS (?bedrock)