Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jun 18, 2024

Description

Completed recolor work for Pane.Splitter, Pane.SplitterButton and <Grid debug>

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@lucijanblagonic
Copy link

Pane.SplitterButton seems to have a light mode shadow in dark mode. It should be 88% / 1100, and not 16% / 200.

image
image

Current vs. updated example on red background to make it clearer.

@jzempel
Copy link
Member Author

jzempel commented Jun 18, 2024

Pane.SplitterButton seems to have a light mode shadow in dark mode. It should be 88% / 1100, and not 16% / 200.

Thanks, @lucijanblagonic. I've updated here and left a comment in Figma.

Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jzempel jzempel merged commit d97aa1b into next Jun 20, 2024
@jzempel jzempel deleted the jzempel/recolor-grid branch June 20, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants