Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

replace-v1 flag breaks migration #45

@okovpashko

Description

@okovpashko

Hello.
Recently I tried to migrate our app to framework v2 and get an error when tried to use --replace-v1 flag.
Here's the full output:

sandro@Sandros-MacBook $ zat migrate --replace-v1
App will be migrated from: /Users/sandro/Work/Projects/devmate/devmate-zendesk-app
App will be migrated to: /Users/sandro/Work/Projects/devmate/devmate-zendesk-app/v2/
? Are you sure you want to replace v1 files? Yes
v1 App will be backed up to: /Users/sandro/Work/Projects/devmate/devmate-zendesk-app/v1/
Warning: `parser` with value "postcss" is deprecated. Use "css", "less" or "scss" instead.
 [==================[22[1m=--] 12/13 steps completemv: cannot move to self: /Users/sandro/Work/Projects/devmate/devmate-zendesk-app/v1
 [====================[22[1m=] 13/13 steps complete
Installing dependencies
yarn install v1.3.2
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "karma-webpack > webpack-dev-middleware@1.8.4" has incorrect peer dependency "webpack@1 || ^2.1.0-beta".
[4/4] Building fresh packages...
Done in 45.27s.
Building v2 app
yarn run v1.3.2
$ webpack -p
Hash: a55139b8c2439aa4b3cf
Version: webpack 3.5.1
Time: 2710ms
     Asset       Size  Chunks                    Chunk Names
   main.js     315 kB       0  [emitted]  [big]  app
  main.css    0 bytes       0  [emitted]         app
index.html  745 bytes          [emitted]         
  [85] (webpack)/buildin/global.js 509 bytes {0} [built]
 [114] multi babel-polyfill ./src/javascripts/index.js ./src/stylesheets/app.scss 52 bytes {0} [built]
 [298] ./src/javascripts/index.js 1.11 kB {0} [built] [failed] [1 error]
 [299] ./src/stylesheets/app.scss 41 bytes {0} [built]
 [300] ./node_modules/css-loader?sourceMap&root=/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/dist/assets!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/stylesheets/app.scss 248 bytes [built]
    + 299 hidden modules

ERROR in ./src/javascripts/index.js
Module build failed: Error: No ESLint configuration found.
    at Config.getLocalConfigHierarchy (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint/lib/config.js:256:39)
    at Config.getConfigHierarchy (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint/lib/config.js:182:43)
    at Config.getConfigVector (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint/lib/config.js:287:21)
    at Config.getConfig (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint/lib/config.js:330:29)
    at processText (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint/lib/cli-engine.js:162:33)
    at CLIEngine.executeOnText (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint/lib/cli-engine.js:668:26)
    at lint (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint-loader/index.js:218:17)
    at Object.module.exports (/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/node_modules/eslint-loader/index.js:213:21)
 @ multi babel-polyfill ./src/javascripts/index.js ./src/stylesheets/app.scss
Child html-webpack-plugin for "index.html":
     1 asset
       [4] ./node_modules/handlebars-loader!./lib/templates/layout.hdbs 2.27 kB {0} [built]
        + 7 hidden modules
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js?sourceMap&root=/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/dist/assets!node_modules/sass-loader/lib/loader.js?sourceMap!src/stylesheets/app.scss:
       [0] ./node_modules/css-loader?sourceMap&root=/Users/sandro/Work/Projects/devmate/devmate-zendesk-app/dist/assets!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/stylesheets/app.scss 248 bytes {0} [built]
        + 1 hidden module
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
undefined
 [====================[22[1m=] 13/13 steps completeError: Promise rejected with value: 'error Command failed with exit code 2.\n'
    at /Users/sandro/.nvm/versions/node/v8.9.1/lib/node_modules/zendesk_app_migrator/node_modules/loud-rejection/index.js:27:12
    at Array.forEach (<anonymous>)
    at EventEmitter.<anonymous> (/Users/sandro/.nvm/versions/node/v8.9.1/lib/node_modules/zendesk_app_migrator/node_modules/loud-rejection/index.js:23:24)
    at emitTwo (events.js:126:13)
    at EventEmitter.emit (events.js:214:7)
    at emit (/Users/sandro/.nvm/versions/node/v8.9.1/lib/node_modules/zendesk_app_migrator/node_modules/signal-exit/index.js:77:11)
    at processEmit [as emit] (/Users/sandro/.nvm/versions/node/v8.9.1/lib/node_modules/zendesk_app_migrator/node_modules/signal-exit/index.js:150:5)

As you can see there's an error Module build failed: Error: No ESLint configuration found.
I noticed that none of "dot" files (.babelrc, .eslintrc, .node-version, .travis.yml) were copied to root directory of the project.

I think I've found the reason for this error and can submit a PR with the fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions