Disable serviceLinks

[uthark]

To not pollute env of the containers, disable serviceLinks by default.
If the deployment explicitly has it, keep as is.

Some back story:

• Docker legacy --links - what causes this.
• K8 feature PR
• K8 issue raised

Risks

• Med - changing default behavior might break existing deployments that rely on it.

[magnetikonline]

I approve @uthark - but just wondering could this break someone's current workflow/deployment I wonder?

If it does, I would strongly advise the owners of the project in the question to avoid using these env vars - but still, might be a breaking change?

[grosser]

yeah, please update risks ... sounds like we have to first find out who uses this to disable or only turn on in staging somehow

[uthark]

It might break, so we need to announce the change and ask people to explicitly set the flag if they rely on this behavior.

[magnetikonline]

Turning on in staging sounds like a good idea no? It should shake out any deployments that fail - of course you need to deploy them first to find out! The vars do have a fairly predictable pattern - could grep GitHub?

DB_NAME=/web2/db
DB_PORT=tcp://172.17.0.5:5432
DB_PORT_5432_TCP=tcp://172.17.0.5:5432
DB_PORT_5432_TCP_PROTO=tcp
DB_PORT_5432_TCP_PORT=5432
DB_PORT_5432_TCP_ADDR=172.17.0.5

[grosser]

we could do some opa rule that says "values must be set to either true/false", but that would fail almost all deploys ... so maybe do that after this rollout for now only setting it on non-production sounds good, I'm still expecting fallout since we at least use the kubernetes ports somewhere ...

…

On Wed, Mar 4, 2020 at 5:36 PM Peter Mescalchin ***@***.***> wrote: Turning on in staging sounds like a good idea no? It should shake out any deployments that fail - of course you need to deploy them first to find out! The vars do have a fairly predictable pattern - could grep GitHub? DB_NAME=/web2/db DB_PORT=tcp://172.17.0.5:5432 DB_PORT_5432_TCP=tcp://172.17.0.5:5432 DB_PORT_5432_TCP_PROTO=tcp DB_PORT_5432_TCP_PORT=5432 DB_PORT_5432_TCP_ADDR=172.17.0.5 — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3742?email_source=notifications&email_token=AAACYZYCYSUZ2ZUGIPZAUTLRF36ZZA5CNFSM4LB7TJRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN3LGLY#issuecomment-594981679>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACYZZ5M7QFH7IJR5O5A73RF36ZZANCNFSM4LB7TJRA>.

[grosser]

we should set that on pod_templates for consistency, not only Deployments, use pod_template