Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max_wait_time usage #179

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Fix max_wait_time usage #179

merged 1 commit into from
Aug 20, 2020

Conversation

edgurgel
Copy link
Contributor

Hi team!

While checking the Statsd metrics that were being sent we noticed that the consumer.loop.duration was being called very frequently and apparently not respecting the max_wait_time configuration.

After applying the change from this PR we got the expected result!

I think I've found the places where the configuration was being sent as seconds but they were expected to be in milliseconds:

def poll(timeout_ms)

I added this method to Racecar::Config to convert it, but happy to do it differently if there's a better way.

I'm also not sure how to write a good test for this change... any suggestions?

Thanks in advance!

@dasch dasch merged commit 8dfe392 into zendesk:master Aug 20, 2020
@dasch
Copy link
Contributor

dasch commented Aug 20, 2020

Thanks!

@dasch
Copy link
Contributor

dasch commented Aug 20, 2020

I've released v2.0.0.beta6. Can you deploy that to production and report back that there are no regressions? Then I think I'm ready to release v2 final.

@edgurgel
Copy link
Contributor Author

edgurgel commented Aug 20, 2020

Sure! We will upgrade the version and report back 👍

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants