Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team!
While checking the Statsd metrics that were being sent we noticed that the
consumer.loop.duration
was being called very frequently and apparently not respecting themax_wait_time
configuration.After applying the change from this PR we got the expected result!
I think I've found the places where the configuration was being sent as seconds but they were expected to be in milliseconds:
racecar/lib/racecar/consumer_set.rb
Line 16 in c9b50ba
I added this method to
Racecar::Config
to convert it, but happy to do it differently if there's a better way.I'm also not sure how to write a good test for this change... any suggestions?
Thanks in advance!