Skip to content

Conversation

pixeldrew
Copy link
Contributor

Require-config should specify location and name of module by filename

This allows you to use path config to specify directory and name is defined by filename for example define(['cross-storage/hub'], function(hub){ ... });
define(['cross-storage/client'], function(client){ ... });

Otherwise you have to make path config entries for each file, this is also more inline with commonjs naming conventions

@pixeldrew
Copy link
Contributor Author

I didn't commit the dist files as I expect you would probably want to version bump and commit them yourself. (if you accept this PR)

@danielstjules
Copy link
Contributor

Thanks for the PR! :) Makes sense to let the module id be derived by file path/name.

danielstjules added a commit that referenced this pull request Oct 20, 2015
Removed named module as this causes portability issues when using r.js
@danielstjules danielstjules merged commit a15c706 into zendesk:master Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants