-
-
Notifications
You must be signed in to change notification settings - Fork 56
Feature preferred layout attributes #135
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # Sources/Shared/Core/BlueprintInvalidationContext.swift
As mentioned, theres currently a bug with the width of the headers/footers on OSX. However this is present in master. There is also a bug with the positioning of the cells when using dynamic heights for the header and footer, again this is present in master. Example: The collection view is at its furthest position and the cell is overlapping. Could this have been broken in #131 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on the comments (Pending tests been resolved, running locally without any issue), we will need to open issues for both items. I will also look at putting an example together for the changes, the example app needs updating for iOS 13 anyways.
@christoff-1992 I'm gonna take a look at why the CI is failing, when that is fixed I think we should aim to get this into |
Adds support for using preferred layout attributes on your cells.