Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Feb 7, 2020

Adds support for using preferred layout attributes on your cells.

@christoff-1992
Copy link
Collaborator

As mentioned, theres currently a bug with the width of the headers/footers on OSX. However this is present in master.

There is also a bug with the positioning of the cells when using dynamic heights for the header and footer, again this is present in master.

Example: The collection view is at its furthest position and the cell is overlapping.

38B78989-6745-4607-9F6C-C4C189D340E6

Could this have been broken in #131

Copy link
Collaborator

@christoff-1992 christoff-1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on the comments (Pending tests been resolved, running locally without any issue), we will need to open issues for both items. I will also look at putting an example together for the changes, the example app needs updating for iOS 13 anyways.

@zenangst
Copy link
Owner Author

zenangst commented Mar 1, 2020

@christoff-1992 I'm gonna take a look at why the CI is failing, when that is fixed I think we should aim to get this into master to force us to fix all the small tiny things that might still be an issue. What do you reckon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants