Skip to content

Conversation

@dangotbanned
Copy link
Contributor

@dangotbanned dangotbanned commented Mar 3, 2025

@dangotbanned
Copy link
Contributor Author

@zen-xu I'm too burned out to finish the rest - but I hope you can see the pattern I've been following in fixing them 👍

@zen-xu
Copy link
Owner

zen-xu commented Mar 4, 2025

This is indeed a tough job

@dangotbanned
Copy link
Contributor Author

@zen-xu could we merge this as-is?

I think the pc.compute functions I've covered are the most general and likely to have the biggest impact.

Especially for us at narwhals 🙂

@zen-xu zen-xu merged commit 93f756d into zen-xu:main Mar 17, 2025
2 checks passed
@zen-xu
Copy link
Owner

zen-xu commented Mar 17, 2025

Thanks

@dangotbanned dangotbanned deleted the compute-overlap branch March 17, 2025 14:45
dangotbanned added a commit to dangotbanned/pyarrow-stubs that referenced this pull request Apr 5, 2025
Follow-up to zen-xu#184, resolves 20+ new warnings in `narwhals` on `17.19`

narwhals-dev/narwhals#2233 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants