Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ping Zeus keybind #729

Merged
merged 10 commits into from
May 20, 2023
Merged

Add Ping Zeus keybind #729

merged 10 commits into from
May 20, 2023

Conversation

ampersand38
Copy link
Member

When merged this pull request will:

@rautamiekka
Copy link
Contributor

Mmmm, I like the sound of that even without the vid.

@Kexanone
Copy link
Member

Could be bound to U by default, which is used in Reforger.

addons/editor/initKeybinds.sqf Outdated Show resolved Hide resolved
@Kexanone Kexanone added the feature Adds a new feature label Apr 16, 2023
@Kexanone Kexanone added this to the 1.14.0 milestone Apr 16, 2023
addons/editor/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/editor/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/editor/stringtable.xml Outdated Show resolved Hide resolved
addons/editor/stringtable.xml Outdated Show resolved Hide resolved
addons/editor/initKeybinds.sqf Outdated Show resolved Hide resolved
addons/editor/initKeybinds.sqf Outdated Show resolved Hide resolved
@mharis001 mharis001 requested a review from Kexanone May 12, 2023 11:46
@mharis001
Copy link
Member

I added a custom ping animation that grows the icon and fades it out near the end as well as being unique per curator and displaying their name. Also, using our own logic for viewing the ping (moving camera), which is mostly the same as base game for positions but different for objects. Finally, switched back to "Zeus" instead of "Curators" in the stringtable but not sure about the plural for "Zeus" so opted for "Zeus curators" in the description.

@ampersand38 and @Kexanone please review and merge when ready.

@mharis001 mharis001 changed the title Ping Curators Add Ping Zeus keybind May 12, 2023
Copy link
Contributor

@rautamiekka rautamiekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I found.

@ampersand38 ampersand38 merged commit e1330bc into zen-mod:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeus ping other zeuses
4 participants