Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display to configure pylon loadouts #424

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Add display to configure pylon loadouts #424

merged 2 commits into from
Jul 23, 2020

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Add display to configure the pylon loadouts of aircraft, Close Feature Request: Pylon/Magazine Loadout Attribute #143
  • Correctly uses the UIposition config entry to ensure pylon controls are positioned on the UI picture the same as 3DEN
  • Wiki says setPylonLoadout command is EL but from testing command seems to be AL EG
Image

pylons

@mharis001 mharis001 added the feature Adds a new feature label Jul 6, 2020
@mharis001 mharis001 added this to the 1.9.0 milestone Jul 6, 2020
@mharis001 mharis001 requested a review from neilzar July 6, 2020 04:33
neilzar
neilzar approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@neilzar neilzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue is the confusing naming of the pylons and loadout buttons, but that can be fixed in a different PR since the loadout button is less descriptive.

@mharis001 mharis001 merged commit c586070 into master Jul 23, 2020
@mharis001 mharis001 deleted the pylons branch July 23, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilzar neilzar neilzar approved these changes

@CreepPork CreepPork CreepPork approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Pylon/Magazine Loadout Attribute
3 participants
@mharis001 @CreepPork @neilzar