Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artillery fire mission spread behaviour #106

Merged
merged 3 commits into from
Aug 16, 2019
Merged

Conversation

mharis001
Copy link
Member

When merged this pull request will:

@mharis001 mharis001 added the bug fix Fixes a bug label Aug 6, 2019
@mharis001 mharis001 added this to the 1.4.0 milestone Aug 6, 2019
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, works like a charm:

But there's again a catch, the AI seem to do a little dance on each round that is fired.

@mharis001
Copy link
Member Author

Yeah, that is the result of having to use doArtilleryFire with one round at a time, I don't think there is another way.

Could just use a single doArtilleryFire when spread is low (<10) since that should produce the expected result in that situation as well. Will help avoid this when using a small spread value, or none.

@Kexanone
Copy link
Member

Yeah, when no spread is selected, just use doArtilleryFire once.

CreepPork
CreepPork previously approved these changes Aug 12, 2019
@mharis001 mharis001 merged commit ae94878 into master Aug 16, 2019
@mharis001 mharis001 deleted the artillery-spread branch August 16, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artillery spread works more like an offset
3 participants