Implemented support for caseFold parameter on Archives File Systems
#17
+121
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-pre
reviewed
Nov 5, 2025
Member
james-pre
left a comment
james-pre
left a comment
There was a problem hiding this comment.
Looking good, I've gotten started with some suggestions to improve the code style and such. Thanks for contributing!
Co-authored-by: James Prevett <jp@jamespre.dev>
Co-authored-by: James Prevett <jp@jamespre.dev>
lvcabral
commented
Nov 5, 2025
Member
|
Also it would be nice to have a new test (or multiple new tests) to make this works correctly. |
james-pre
reviewed
Nov 7, 2025
Member
james-pre
left a comment
james-pre
left a comment
There was a problem hiding this comment.
Looks good so far. I have some very minor feedback but I think it is almost ready to merge.
| for (const part of path.split('/').slice(1)) { | ||
| if (!dir.isDirectory()) return; | ||
| dir = dir.directory.get(part); | ||
| const directory: Directory = dir.directory; |
Member
There was a problem hiding this comment.
Suggested change
| const directory: Directory = dir.directory; | |
| const { directory } = dir; |
Comment on lines
+140
to
151
| if (!next && this.options.caseFold) { | ||
| const foldedPart = this._caseFold(part); | ||
| for (const [name, record] of directory) { | ||
| if (this._caseFold(name) === foldedPart) { | ||
| next = record; | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dir = next; | ||
| if (!dir) return; |
Member
There was a problem hiding this comment.
This is kind of difficult to read... if there is a way to make it more readable & reduce indentation that would be great— perhaps using a gaurd clause?
Comment on lines
+157
to
+163
| private _caseFold(original: string): string { | ||
| if (!this.options.caseFold) { | ||
| return original; | ||
| } | ||
|
|
||
| return this.options.caseFold === 'upper' ? original.toUpperCase() : original.toLowerCase(); | ||
| } |
Member
There was a problem hiding this comment.
This is duplicated with ZipFS as well. To reduce duplcation, I'm thinking:
- Make
optionspublicbut add@internal - Change case fold to be
@internal, and take the FS:_caseFold(fs: FileSystem, path: string) => string - Both FSes use the shared case fold function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented both ISO and ZIP and added Unit Tests