gh-14168: Fix collapsed workspace toggle hitbox

[bnquon]

follows the suggested approach from the original issue by preventing the workspace actions button from appearing on hover in the collapsed sidebar. this keeps the space icon visible and clickable for collapsing pinned tabs, while the actions menu remains right-clickable.

demo showing sidebar toggling and the style fixes for the hover

zen-issue-14168-demo.mp4

closes #14168

[bnquon]

while testing these changes, i noticed that the workspace action in a collapsed unsynced/blank window has no visible icon or label in the current release. the tooltip appears and the action still works when clicked, but the button itself looks blank, as shown while hovering in the attached image.

this is unrelated to the changes in this pr, so i preserved the existing behavior. should this be addressed separately, or would you prefer that i include some suggested change in this PR?

from the current release, red arrow added to show where my cursor is hovering during SS, on top of the blank window workspace collapsed icon

[mr-cheffy]

Sure, you can address it here

[bnquon]

Sure, you can address it here

added a dedicated icon class for the move to space action in blank windows. contemplated between this icon and the open icon, but went with the corner-down-right arrow since it’s less commonly used elsewhere and felt clearer for moving something. the tooltip and expanded sidebar behavior still work too

zen-issue-14168-followup-demo.mov

[mr-cheffy]

Only concern I have so far is that maybe people are used to simply click on the three dots for the workspace actions, but thats not possible anymore...

[bnquon]

yeah fair, although i do think this is cleaner than adding another button or finding a separate place for the collapsed action, and it better matches the click behavior of the expanded sidebar

[mr-cheffy]

What about making it float to the top left? Like the close buttons on tabs

[bnquon]

What about making it float to the top left? Like the close buttons on tabs

i was able to get it looking like this by adding the same Firefox css from the collapsed tab close button. i checked the left alignment using Shottr’s (screenshot app) ruler, and it looks to have the same gap as the buttons on tabs. the only difference is that i used 1px less padding to make the three dots look a little bigger and clearer. this only applies to normal workspaces, the blank windows keep the move to space arrow from the earlier change.

if this looks fine and you want to go with this lmk and i can commit my local changes

(hovered workspace icon in sidebar view)

[mr-cheffy]

That looks great!

[bnquon]

okay sounds good! committed those changes

[mr-cheffy]

What's up with these weird attributes being added? Seems really vibecoded. color-scheme as well, etc...

[bnquon]

these are taken from Firefox’s base tab close button styles and collapsed vertical tab close button styles for consistency