fix: detect external Firefox profiles during first-run migration - #14743
Open
borscht-enjoyer wants to merge 1 commit into
Open
fix: detect external Firefox profiles during first-run migration#14743borscht-enjoyer wants to merge 1 commit into
borscht-enjoyer wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import wizard at first launch cant see Firefox even when its installed on the same machine, falls back to manual file picker. this has been an open complaint since early 2024
the bug: FirefoxProfileMigrator.getAllProfiles uses nsIToolkitProfileService to list profiles but that service only knows about Zen profiles since Zen has its own profile directory. Firefox profiles are invisible to it
the fix: monkey patches getAllProfiles to also scan Firefoxs profiles.ini from the standard os directories, parses ProfileX sections with Name and Path and IsRelative, resolves them to real directories, merges into results. build time patch does the same thing baked into the source as a backup
tested locally with various profiles.ini inputs
Fixes: #881