Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move layout.rs from server to utils #576

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Jun 14, 2021

  • give feedback on most errors in the layout-file

@a-kenji
Copy link
Contributor Author

a-kenji commented Jun 14, 2021

@TheLostLambda
Thank you for checking the errors!
Do you think it can lead to problems omitting the

#[serde(skip_serializing_if = "Option::is_none")]

attributes, or is the struct just slightly larger now?

@TheLostLambda
Copy link
Member

@TheLostLambda
Thank you for checking the errors!
Do you think it can lead to problems omitting the

#[serde(skip_serializing_if = "Option::is_none")]

attributes, or is the struct just slightly larger now?

I think that should be fine. I think this is actually the only place the struct is serialised at the moment? If I recall correctly it may have once been intended to produce cleaner outputs when saving a layout from Zellij, but having an empty YAML field really isn't too bad, I don't think :)

@a-kenji
Copy link
Contributor Author

a-kenji commented Jun 15, 2021

Thank you!
Yes it is the only location that serializes the struct currently.

@a-kenji a-kenji merged commit 64d639b into zellij-org:main Jun 15, 2021
@a-kenji a-kenji deleted the layout-error branch June 15, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants