Errors: Ignore errors from async when quitting

CHANGELOG.md

@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ## [Unreleased]
 
 * feat: support text input from clipboard (https://github.com/zellij-org/zellij/pull/1926)
+* errors: Don't log errors from panes when quitting zellij (https://github.com/zellij-org/zellij/pull/1918)
 
 ## [0.33.0] - 2022-11-10
 

zellij-server/src/terminal_bytes.rs

@@ -120,9 +120,23 @@ impl TerminalBytes {
                 },
             }
         }
-        self.async_send_to_screen(ScreenInstruction::Render)
-            .await
-            .with_context(err_context)?;
+
+        // Ignore any errors that happen here.
+        // We only leave the loop above when the pane exits. This can happen in a lot of ways, but
+        // the most problematic is when quitting zellij with `Ctrl+q`. That is because the channel
+        // for `Screen` will have exited already, so this send *will* fail. This isn't a problem
+        // per-se because the application terminates anyway, but it will print a lengthy error
+        // message into the log for every pane that was still active when we quit the application.
+        // This:
+        //
+        // 1. Makes the log rather pointless, because even when the application exits "normally",
+        //    there will be errors inside and
+        // 2. Leaves the impression we have a bug in the code and can't terminate properly
+        //
+        // FIXME: Ideally we detect whether the application is being quit and only ignore the error
+        // in that particular case?
+        let _ = self.async_send_to_screen(ScreenInstruction::Render).await;
+
         Ok(())
     }
     async fn async_send_to_screen(

zellij-utils/src/errors.rs

@@ -565,13 +565,14 @@ mod not_wasm {
                 Err(e) => {
                     let (msg, context) = e.into_inner();
                     if *crate::consts::DEBUG_MODE.get().unwrap_or(&true) {
-                        Err(
-                            crate::anyhow::anyhow!("failed to send message to channel: {:#?}", msg)
-                                .context(context.to_string()),
-                        )
+                        Err(crate::anyhow::anyhow!(
+                            "failed to send message to channel: {:#?}",
+                            msg
+                        ))
+                        .with_context(|| context.to_string())
                     } else {
-                        Err(crate::anyhow::anyhow!("failed to send message to channel")
-                            .context(context.to_string()))
+                        Err(crate::anyhow::anyhow!("failed to send message to channel"))
+                            .with_context(|| context.to_string())
                     }
                 },
             }