improve error handling in ui module #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @har7an , could you please review this pr? |
har7an
requested changes
Oct 28, 2022
Comment on lines
+248
to
+255
| .fatal() | ||
| .cmp( | ||
| &self | ||
| .z_indices | ||
| .iter() | ||
| .position(|id| id == *b_id) | ||
| .with_context(err_context) | ||
| .fatal(), |
There was a problem hiding this comment.
Why are you using .fatal() instead of ? here?
There was a problem hiding this comment.
Because returning result is not allowed in a closure
There was a problem hiding this comment.
Ah, I missed the closure above, my bad!
|
And on a sidenote, it seems you beat me to the change in But that's okay, since your PR touches many more things I'll close mine and we'll go with yours instead. |
|
Thank you for your patient review, I learned a lot from your comments |
har7an
approved these changes
Oct 28, 2022
har7an
added a commit
that referenced
this pull request
Oct 28, 2022
Remove calls to `unwrap` in `zellij_server::ui::*`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing unwrap in
uimodule with error propagation.Related to #1753