-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: Improve error handling on plugin version mismatch #1838
plugins: Improve error handling on plugin version mismatch #1838
Commits on Oct 22, 2022
-
server/tab: Don't panic in
Pane::render
and do not crash the application on failure to receive a render update from plugins any longer. Instead, will print a simple string with a hint to check the application logs, where a more thorough error indication can be found.
Configuration menu - View commit details
-
Copy full SHA for 2dcd76a - Browse repository at this point
Copy the full SHA 2dcd76aView commit details -
utils/errors: re-export
anyhow::Error
to create ad-hoc errors with custom error types, without having to wrap them into a `context()` before to turn the into anyhow errors.
Configuration menu - View commit details
-
Copy full SHA for 5e33922 - Browse repository at this point
Copy the full SHA 5e33922View commit details -
plugins: Check plugin version on startup
and terminate execution with a descriptive error message in case the plugin version is incompatible with the version of zellij being run.
Configuration menu - View commit details
-
Copy full SHA for 3ae383a - Browse repository at this point
Copy the full SHA 3ae383aView commit details -
server/wasm_vm: Add plugin path in version error
so the user knows which plugin to look at in case they're using custom plugins.
Configuration menu - View commit details
-
Copy full SHA for 762fc54 - Browse repository at this point
Copy the full SHA 762fc54View commit details -
server/wasm_vm: Check plugin version for equality
Previously we would accept cases where the plugin version was newer than the zellij version, which doesn't make a lot of sense.
Configuration menu - View commit details
-
Copy full SHA for d8ee985 - Browse repository at this point
Copy the full SHA d8ee985View commit details
Commits on Oct 23, 2022
-
server/wasm_vm: Prettier error handling
in call to `wasmer::Function::call` in case a plugin version mismatch can occur.
Configuration menu - View commit details
-
Copy full SHA for 7880416 - Browse repository at this point
Copy the full SHA 7880416View commit details -
tile: Install custom panic handler
that will print the panic message to a plugins stdout and then call a panic handler on the host that turns it into a real application-level panic.
Configuration menu - View commit details
-
Copy full SHA for 83ea39b - Browse repository at this point
Copy the full SHA 83ea39bView commit details -
tile: Catch errors in event deserialization
and turn them into proper panics. These errors are symptomatic of an uncaught plugin version mismatch, for example when developing from main and compiling zellij/the plugins from source. Normal users should never get to see this error.
Configuration menu - View commit details
-
Copy full SHA for 13fa4cd - Browse repository at this point
Copy the full SHA 13fa4cdView commit details -
utils/errors: Improve output in
to_stdout
for anyhow errors. The default anyhow error formatting of `{:?}` is already very good, and we just made it worse by trying to invent our own formatting.
Configuration menu - View commit details
-
Copy full SHA for 77b9648 - Browse repository at this point
Copy the full SHA 77b9648View commit details -
Configuration menu - View commit details
-
Copy full SHA for af82b81 - Browse repository at this point
Copy the full SHA af82b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78ab8db - Browse repository at this point
Copy the full SHA 78ab8dbView commit details -
changelog: Add PR zellij-org#1838
Improve error handling on plugin version mismatch.
Configuration menu - View commit details
-
Copy full SHA for 6904ede - Browse repository at this point
Copy the full SHA 6904edeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f6932 - Browse repository at this point
Copy the full SHA 23f6932View commit details