fix(terminal): properly trim lines with widechars on resize #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1206
This also happens when we simply resize the pane without even opening vim or a similar app. The latter happens because we call the resize/reflow method when moving away from an alternative screen (in case the scrollback was resized somewhere in between).
In such a case, we trim lines after the last whitespace to that we won't reflow needless whitespace (eg. have a wrapped line with only whitespace). This mechanism wasn't wide-char aware, and because of that this bug was created. I adjusted it and it now works.