Skip to content

Add logging to ipc receiver #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2022
Merged

Add logging to ipc receiver #1459

merged 3 commits into from
Jun 7, 2022

Conversation

raphCode
Copy link
Contributor

@raphCode raphCode commented Jun 6, 2022

#1445

@a-kenji does this look like you imagined?

Example log message:

WARN   |zellij_utils::ipc        | 2022-06-07 01:51:22.924 [server_router] [zellij-utils/src/ipc.rs:194]: Error in IpcReceiver.recv(): Io(Error { kind: UnexpectedEof, message: "failed to fill whole buffer" })
ERROR  |zellij_server::route     | 2022-06-07 01:51:22.925 [server_router] [zellij-server/src/route.rs:522]: Received empty message from client

@raphCode raphCode requested a review from a-kenji June 6, 2022 23:57
@raphCode raphCode temporarily deployed to cachix June 6, 2022 23:57 Inactive
@raphCode raphCode temporarily deployed to cachix June 6, 2022 23:57 Inactive
@raphCode raphCode linked an issue Jun 7, 2022 that may be closed by this pull request
Feat: Log Reason, why Empty Message is send from a client. #1445
Closed
a-kenji
a-kenji approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphCode raphCode temporarily deployed to cachix June 7, 2022 15:14 Inactive
@raphCode raphCode temporarily deployed to cachix June 7, 2022 15:14 Inactive
@raphCode raphCode merged commit 92c5c6c into main Jun 7, 2022
@har7an har7an deleted the log-empty-msg branch October 23, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@a-kenji a-kenji a-kenji approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Log Reason, why Empty Message is send from a client.
2 participants
@raphCode @a-kenji