Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double panic lockup in clients panic handler #1433

Merged
merged 5 commits into from
May 24, 2022
Merged

Commits on May 23, 2022

  1. Fix possible lockup in the clients panic handler

    When the pty the client was running in disappears, reading from stdin
    causes a panic, which triggers the custom panic handler. This handler
    attempts to print a backtrace to the terminal and tries to unset the raw
    mode for that. Since the pty has already disappeared, the tcsetattr call
    fails and causes a second panic, which locks everything up.
    
    This commit fixes this by returning an Result from the unset_raw_mode
    function, allowing the calling panic handler to handle any error
    gracefully.
    raphCode committed May 23, 2022
    Configuration menu
    Copy the full SHA
    1f586ce View commit details
    Browse the repository at this point in the history
  2. Log any client panics to file

    Since we are now aware of the fact that panics may happen / are handled
    after the pty has disappeared, logging them to file seems useful: there
    is no other other place to show them to the user.
    raphCode committed May 23, 2022
    Configuration menu
    Copy the full SHA
    9b65919 View commit details
    Browse the repository at this point in the history
  3. rustfmt

    raphCode committed May 23, 2022
    Configuration menu
    Copy the full SHA
    742435e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    531c9c3 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. rustfmt

    raphCode committed May 24, 2022
    Configuration menu
    Copy the full SHA
    847f3dc View commit details
    Browse the repository at this point in the history