Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Refactor/streamline keybindings #1103

Closed
wants to merge 5 commits into from
Closed

WIP: Refactor/streamline keybindings #1103

wants to merge 5 commits into from

Commits on Feb 23, 2022

  1. utils: keybinds: Add comments, remove dead code 

    Expand the documentation on some of the structs and functions to clarify
their purpose in the parsing of the keybindings configuration.
Also remove an intermediate struct once used for parsing that isn't
referenced anywhere else in the code.
    @har7an
    har7an committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    b75c1b1 View commit details
    Browse the repository at this point in the history

  2. utils: keybinds: Drop from_default_assets() 

    in favor of using the `default()` trait.
    @har7an
    har7an committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    ccbecb9 View commit details
    Browse the repository at this point in the history

  3. utils: keybinds: Add normal mode binds by default 

    to all other keybinds. This ensures that the user has a consistent user
experience and all the basic commands/movements (to switch modes, or the
default "Alt"-bindings) can be changed in one place.
If the need arises, specific bindings can still be overriden in the
config file on a per-mode basis, as needed.
    @har7an
    har7an committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    6835481 View commit details
    Browse the repository at this point in the history

  4. FIXME: input: keybinds: Disable tests 

    to test the feature manually from the CLI.
    @har7an
    har7an committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    ff178d1 View commit details
    Browse the repository at this point in the history

  5. assets: default.yaml: Deduplicate keybindings 

    because the `normal`-mode bindings are now applied by default to all
other modes, so the repetitions aren't necessary any longer.
    @har7an
    har7an committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    659833b View commit details
    Browse the repository at this point in the history