Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lightline like toolbars [Feature Request] #313

Closed
alexhallam opened this issue Apr 21, 2021 · 5 comments · Fixed by #479
Closed

More lightline like toolbars [Feature Request] #313

alexhallam opened this issue Apr 21, 2021 · 5 comments · Fixed by #479
Labels
enhancement New feature or request

Comments

@alexhallam
Copy link

I have a very minimal set up.

When I open the multiplexer this is what my toolbar looks like.

image

I would like to request a simplified version that does not have the font/glyph deps. Something like a light line option (see https://github.com/itchyny/lightline.vim)

image

@alexhallam alexhallam changed the title More lightline like toolbars More lightline like toolbars [Feature Request] Apr 21, 2021
@a-kenji a-kenji added the enhancement New feature or request label Apr 21, 2021
@a-kenji
Copy link
Contributor

a-kenji commented Apr 22, 2021

Thank you! Currently we have no configuration system for themes and plugins implemented yet, but the font issue has come up often enough, that I think it is reasonable to try to build the bar with a more general font and include it by default, so people can switch it out in their default.yaml - as an intermediary fix. I am curious what other people think.

cc @imsnif

@keeslinp
Copy link

Worst case someone could just make a new wasm plugin and load a different layout right? (or just replace the status-bar.wasm file I guess)

@imsnif
Copy link
Member

imsnif commented Apr 23, 2021

A relatively quick fix for this (in case users don't want to install new fonts) is:

  1. Create versions of the default plugins (status-bar and tab-bar) as @keeslinp suggested, which do not include the arrow font (or include a different separator instead it, maybe a pipe?)
  2. Create a "simplified.yaml" layout which is the copy of the default layout and loads them instead
  3. Run: zellij --layout simplified

If anyone wants to work on this, I'd be happy to merge this PR. I think this would be valuable to include with Zellij.

Bonus points if you can come up with a better name than "simplified" :)

@alexhallam
Copy link
Author

I can give this a try. But I have a couple questions first:

  1. For new versions of status-bar and tab-bar I am guessing I just cp default-plugins/status-bar/src/main.rs and ./default-plugins/tab-bar/src/main.rs to something like default-plugins/status-bar-simple/src/main.rs and ./default-plugins/tab-bar-simple/src/main.rs and make the edits. From there I will have to read the docs.
  2. I see ./example/default.yaml I am just going to cp that to ./example/simplified.yaml and make the edits.
  3. I will have to dig in to find where command line args are called. So I can add the --layout flag.
  4. I will skip the bonus points, but if someone else has a better name than simplified I am all ears. haha

@a-kenji
Copy link
Contributor

a-kenji commented Apr 30, 2021

Hey @alexhallam , that would be awesome!

For new versions of status-bar and tab-bar I am guessing I just cp default-plugins/status-bar/src/main.rs and ./default-plugins/tab-bar/src/main.rs to something like default-plugins/status-bar-simple/src/main.rs and ./default-plugins/tab-bar-simple/src/main.rs and make the edits. From there I will have to read the docs.

Yes!

I see ./example/default.yaml I am just going to cp that to ./example/simplified.yaml and make the edits.

Almost, you want /assets/layouts/default.yaml and can create an /assets/layouts/simplified.yaml

I will have to dig in to find where command line args are called. So I can add the --layout flag.

You don't need to do that, when calling with the --layout flag zellij looks in the layout dir, or currently still the path you provide.
So you can test by providing the path to your current layout file, in this case
--layout /assets/layouts/simplified.yaml
If you overwrite the default layout, that zellij creates on startup for you, with the simplified.yaml then zellij would startup every time with the simplified version.

I will skip the bonus points, but if someone else has a better name than simplified I am all ears.

I think its an apt name, but yes it is not very flashy.

If you have any more questions please don't hesitate with asking them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants