Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for Simplified Layout #479

Merged
merged 7 commits into from
May 11, 2021
Merged

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented May 10, 2021

  • the simplified layout omits the Nerdfonts characters that are not
    found in every Fontset

  • add an optional config option to opt into the simplified ui
    simplified_ui: bool

  • add a config flag that allows opting into the simplified ui
    zellij options --simplified-ui

  • move the clean flag to the setup subcommand

Closes #313.

* the simplified layout omits the Nerdfonts characters that are not
  found in every Fontset

* add an optional config option to opt into the simplified ui
  `simplified_ui: bool`

* add a config flag that allows opting into the simplified ui
  `zellij options --simplified-ui`

* move the `clean` flag to the `setup` subcommand
@a-kenji a-kenji mentioned this pull request May 10, 2021
@matu3ba
Copy link
Contributor

matu3ba commented May 10, 2021

Now that you noticed nerdfonts as dependencies: Could you add this requirement as follow-up PR to https://github.com/zellij-org/zellij#how-do-i-install-it as optional dependency?

@a-kenji
Copy link
Contributor Author

a-kenji commented May 10, 2021

We always noticed them as dependencies, we just haven't had a good way of requesting a simpler layout yet. Thanks for the suggestion, that is a good idea!

@a-kenji
Copy link
Contributor Author

a-kenji commented May 10, 2021

@TheLostLambda
Would it make sense to let people choose the separator character?
Or is that something that shouldn't be propagated?

@a-kenji a-kenji marked this pull request as ready for review May 11, 2021 20:04
@a-kenji a-kenji merged commit 38b8f64 into zellij-org:main May 11, 2021
@a-kenji a-kenji deleted the simple-font-ui branch May 11, 2021 20:09
@alexhallam
Copy link

@a-kenji I personally did not see much value in separators. The colors/layout/highlighting in zellij seemed sufficient to me. This is a subjective opinion.

@a-kenji
Copy link
Contributor Author

a-kenji commented May 11, 2021

@alexhallam
Thank you for the input!

Does the current functionality work for you?

add an optional config option to opt into the simplified ui
simplified_ui: true

add a config flag that allows opting into the simplified ui
zellij options --simplified-ui

@alexhallam
Copy link

I just did a new git clone

zellij options --simplified-ui

image

zellij --simplified-ui

image

I am not sure what I am doing wrong

@a-kenji
Copy link
Contributor Author

a-kenji commented May 12, 2021

That is indeed a little odd.
Do you mind checking:

zellij --version

and

zellij options --help

please also try

zellij option --help

Thank you!

@alexhallam
Copy link

Just want to let you know I just downloaded the most recent version. Everything is working great. Thanks for implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More lightline like toolbars [Feature Request]
3 participants