Additional documentation for z_skin system - #2804
Open
Thar0 wants to merge 4 commits into
Open
Conversation
fig02
reviewed
Aug 18, 2026
fig02
left a comment
fig02
left a comment
Collaborator
There was a problem hiding this comment.
woah imagine me reviewing something, I promise I'll be back for real someday ™️
Dragorn421
reviewed
Aug 19, 2026
Dragorn421
reviewed
Aug 28, 2026
| */ | ||
| typedef struct SkinVertex { | ||
| /* 0x00 */ u16 index; | ||
| /* 0x00 */ u16 index; // output vertex buffer index |
Collaborator
There was a problem hiding this comment.
Suggested change
| /* 0x00 */ u16 index; // output vertex buffer index | |
| /* 0x00 */ u16 index; // index into the output vertex buffer |
| /** | ||
| * Holds a compact version of a vertex used in the Skin system | ||
| * It is used to initialise the Vtx used by an animated limb | ||
| * It is used to initialise the Vtx used by an animated limb to common data |
Collaborator
There was a problem hiding this comment.
Suggested change
| * It is used to initialise the Vtx used by an animated limb to common data | |
| * It is used to initialize the Vtx used by an animated limb to common data |
| /* 0x02 */ u16 transformCount; | ||
| /* 0x04 */ u16 unk_4; // index of limbTransformations? | ||
| /* 0x02 */ u16 transformCount; // number of transformations | ||
| /* 0x04 */ u16 staticLimbTransformationIndex; // indicates where to find the limb-space normal, or if singleBindFlag where to also find the limb-space position |
Collaborator
There was a problem hiding this comment.
Suggested change
| /* 0x04 */ u16 staticLimbTransformationIndex; // indicates where to find the limb-space normal, or if singleBindFlag where to also find the limb-space position | |
| /* 0x04 */ u16 mainBindLimbTransformationIndex; // indicates where to find the limb-space normal, or if singleBindFlag where to also find the limb-space position |
I wouldn't be surprised if that value is the one with most weight in the multi-bind path, so I'd call it "main"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent fast64 work to support this system inspired me to take another look at this and document it some more.