Merge pull request docker#1572 from thaJeztah/minor_test_nit

silvin-lubecki · web-flow · commit 308b1f340ab3 · 2019-01-08T10:17:01.000+01:00
TestRunLabel: pass detach as argument
diff --git a/cli/command/container/run_test.go b/cli/command/container/run_test.go
@@ -23,8 +23,7 @@ func TestRunLabel(t *testing.T) {
 		Version: "1.36",
 	})
 	cmd := NewRunCommand(cli)
-	cmd.Flags().Set("detach", "true")
-	cmd.SetArgs([]string{"--label", "foo", "busybox"})
+	cmd.SetArgs([]string{"--detach=true", "--label", "foo", "busybox"})
 	assert.NilError(t, cmd.Execute())
 }
 

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,7 @@ func TestRunLabel(t *testing.T) {`
`23`	`23`	`Version: "1.36",`
`24`	`24`	`})`
`25`	`25`	`cmd := NewRunCommand(cli)`
`26`		`- cmd.Flags().Set("detach", "true")`
`27`		`- cmd.SetArgs([]string{"--label", "foo", "busybox"})`
	`26`	`+ cmd.SetArgs([]string{"--detach=true", "--label", "foo", "busybox"})`
`28`	`27`	`assert.NilError(t, cmd.Execute())`
`29`	`28`	`}`
`30`	`29`