TestRunLabel: pass detach as argument #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
- Coverage 55.26% 55.24% -0.02%
==========================================
Files 289 289
Lines 19385 19381 -4
==========================================
- Hits 10713 10707 -6
- Misses 7977 7978 +1
- Partials 695 696 +1 |
|
@dnephin @AkihiroSuda ptal 🤗 |
AkihiroSuda
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My IDE was complaining about not checking the error returned by
cmd.Flags().Set()Wasn't sure why detach was set this way, but passing it as
arglooks to work as well